Proposal: update service-config.xsd to reflect what is currently supported in OFBiz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Proposal: update service-config.xsd to reflect what is currently supported in OFBiz

Jacopo Cappellato-4
I would like to updated the service-config.xsd file in the following way:

Index: framework/service/dtd/service-config.xsd
===================================================================
--- framework/service/dtd/service-config.xsd (revision 1365888)
+++ framework/service/dtd/service-config.xsd (working copy)
@@ -22,7 +22,7 @@
     <xs:element name="service-config">
         <xs:complexType>
             <xs:sequence>
-                <xs:element minOccurs="1" maxOccurs="unbounded" ref="service-engine"/>
+                <xs:element minOccurs="1" maxOccurs="1" ref="service-engine"/>
             </xs:sequence>
         </xs:complexType>
     </xs:element>
@@ -39,7 +39,7 @@
                 <xs:element minOccurs="0" maxOccurs="unbounded" ref="global-services"/>
                 <xs:element minOccurs="0" maxOccurs="unbounded" ref="service-groups"/>
                 <xs:element minOccurs="0" maxOccurs="unbounded" ref="service-ecas"/>
-                <xs:element minOccurs="0" maxOccurs="unbounded" ref="jms-service"/>
+                <xs:element minOccurs="0" maxOccurs="1" ref="jms-service"/>
             </xs:sequence>
             <xs:attributeGroup ref="attlist.service-engine"/>
         </xs:complexType>


The idea is that:

1) only one <service-engine> will be allowed; this is what is currently supported and all the service code is implemented with this assumption (static methods etc... that prevents the ability to define more than one service-config); also, it seems that no one really had the need to define more than one service configuration

2) zero or one <jms-service> element in the <service-engine>; again, this is what is currently supported; you still can define several servers (JMS Providers) within the <jms-service> element; I don't see a reason for defining more than one jms-service within the same service-engine configuration.

Regards,

Jacopo
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: update service-config.xsd to reflect what is currently supported in OFBiz

Jacopo Cappellato-4
Hmmm... please ignore this for now, I need more time to study the code.

Jacopo

On Jul 26, 2012, at 2:39 PM, Jacopo Cappellato wrote:

> I would like to updated the service-config.xsd file in the following way:
>
> Index: framework/service/dtd/service-config.xsd
> ===================================================================
> --- framework/service/dtd/service-config.xsd (revision 1365888)
> +++ framework/service/dtd/service-config.xsd (working copy)
> @@ -22,7 +22,7 @@
>     <xs:element name="service-config">
>         <xs:complexType>
>             <xs:sequence>
> -                <xs:element minOccurs="1" maxOccurs="unbounded" ref="service-engine"/>
> +                <xs:element minOccurs="1" maxOccurs="1" ref="service-engine"/>
>             </xs:sequence>
>         </xs:complexType>
>     </xs:element>
> @@ -39,7 +39,7 @@
>                 <xs:element minOccurs="0" maxOccurs="unbounded" ref="global-services"/>
>                 <xs:element minOccurs="0" maxOccurs="unbounded" ref="service-groups"/>
>                 <xs:element minOccurs="0" maxOccurs="unbounded" ref="service-ecas"/>
> -                <xs:element minOccurs="0" maxOccurs="unbounded" ref="jms-service"/>
> +                <xs:element minOccurs="0" maxOccurs="1" ref="jms-service"/>
>             </xs:sequence>
>             <xs:attributeGroup ref="attlist.service-engine"/>
>         </xs:complexType>
>
>
> The idea is that:
>
> 1) only one <service-engine> will be allowed; this is what is currently supported and all the service code is implemented with this assumption (static methods etc... that prevents the ability to define more than one service-config); also, it seems that no one really had the need to define more than one service configuration
>
> 2) zero or one <jms-service> element in the <service-engine>; again, this is what is currently supported; you still can define several servers (JMS Providers) within the <jms-service> element; I don't see a reason for defining more than one jms-service within the same service-engine configuration.
>
> Regards,
>
> Jacopo