|
Hi all,
My client has a requirement for XHTML 1.0 Strict compliance in their OFBiz implementatoin. I've been hunting around and discovered that the DOCTYPE is set in the class org.ofbiz.widget.html.HtmlScreenRenderer in the renderScreenBegin() method. Now I could simply change the line of code or extend HtmlScreenRenderer, but I was thinking that it might be better to have this setting in a configuration file somewhere instead (perhaps in common/config/general.properties?). I would be interested to hear your thoughts. Cheers, Adrian Cumiskey. |
|
Converting hard-coded settings to configuration files is always encouraged.
-Adrian Adrian Cumiskey wrote: > Hi all, > > My client has a requirement for XHTML 1.0 Strict compliance in their OFBiz > implementatoin. I've been hunting around and discovered that the DOCTYPE is > set in the class org.ofbiz.widget.html.HtmlScreenRenderer in the > renderScreenBegin() method. Now I could simply change the line of code or > extend HtmlScreenRenderer, but I was thinking that it might be better to > have this setting in a configuration file somewhere instead (perhaps in > common/config/general.properties?). I would be interested to hear your > thoughts. > > Cheers, > > Adrian Cumiskey. > |
|
This is probably something that should be in the decorator templates. Then it can be customized along with the other HTML. -David On Dec 17, 2009, at 9:54 AM, Adrian Crum wrote: > Converting hard-coded settings to configuration files is always encouraged. > > -Adrian > > Adrian Cumiskey wrote: >> Hi all, >> My client has a requirement for XHTML 1.0 Strict compliance in their OFBiz >> implementatoin. I've been hunting around and discovered that the DOCTYPE is >> set in the class org.ofbiz.widget.html.HtmlScreenRenderer in the >> renderScreenBegin() method. Now I could simply change the line of code or >> extend HtmlScreenRenderer, but I was thinking that it might be better to >> have this setting in a configuration file somewhere instead (perhaps in >> common/config/general.properties?). I would be interested to hear your >> thoughts. >> Cheers, >> Adrian Cumiskey. |
|
That would be cool, but the DOCTYPE element is emitted before any
widgets are rendered. It is set up that way so no widget comments or other markup can precede the DOCTYPE element. -Adrian David E Jones wrote: > This is probably something that should be in the decorator templates. Then it can be customized along with the other HTML. > > -David > > > On Dec 17, 2009, at 9:54 AM, Adrian Crum wrote: > >> Converting hard-coded settings to configuration files is always encouraged. >> >> -Adrian >> >> Adrian Cumiskey wrote: >>> Hi all, >>> My client has a requirement for XHTML 1.0 Strict compliance in their OFBiz >>> implementatoin. I've been hunting around and discovered that the DOCTYPE is >>> set in the class org.ofbiz.widget.html.HtmlScreenRenderer in the >>> renderScreenBegin() method. Now I could simply change the line of code or >>> extend HtmlScreenRenderer, but I was thinking that it might be better to >>> have this setting in a configuration file somewhere instead (perhaps in >>> common/config/general.properties?). I would be interested to hear your >>> thoughts. >>> Cheers, >>> Adrian Cumiskey. > > |
|
+1 for moving it to a config file. This is something that I have always found to be a little annoying.
Ryan Foster HotWax Media 801.671.0769 [hidden email] On Dec 17, 2009, at 9:11 AM, Adrian Crum wrote: > That would be cool, but the DOCTYPE element is emitted before any widgets are rendered. It is set up that way so no widget comments or other markup can precede the DOCTYPE element. > > -Adrian > > David E Jones wrote: >> This is probably something that should be in the decorator templates. Then it can be customized along with the other HTML. >> -David >> On Dec 17, 2009, at 9:54 AM, Adrian Crum wrote: >>> Converting hard-coded settings to configuration files is always encouraged. >>> >>> -Adrian >>> >>> Adrian Cumiskey wrote: >>>> Hi all, >>>> My client has a requirement for XHTML 1.0 Strict compliance in their OFBiz >>>> implementatoin. I've been hunting around and discovered that the DOCTYPE is >>>> set in the class org.ofbiz.widget.html.HtmlScreenRenderer in the >>>> renderScreenBegin() method. Now I could simply change the line of code or >>>> extend HtmlScreenRenderer, but I was thinking that it might be better to >>>> have this setting in a configuration file somewhere instead (perhaps in >>>> common/config/general.properties?). I would be interested to hear your >>>> thoughts. >>>> Cheers, >>>> Adrian Cumiskey. |
| Free forum by Nabble | Edit this page |
