Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Mark Schneider
Hello,

Are you interested in some cosmetic pachtes like the one attached?
(to get more common look for all subscreens of ecommerce)

apache-ofbiz-12.04.01/specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Further I could add some non-existing UiLabels for German to/for eCommerce.
(in case you are interested)

regards, Mark

--
[hidden email]

http://rsync.it-infrastrukturen.org


minipromotext.ftl.diff (1K) Download Attachment
minipromotext.ftl_common_look.png.zip (54K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Varun Bhansaly
The best way to contribute is by creating a JIRA issue and attaching
patches therein, this link
https://cwiki.apache.org/OFBADMIN/ofbiz-contributors-best-practices.html
 should help.


On Sun, Apr 7, 2013 at 9:38 PM, Mark Schneider <[hidden email]>wrote:

> Hello,
>
> Are you interested in some cosmetic pachtes like the one attached?
> (to get more common look for all subscreens of ecommerce)
>
> apache-ofbiz-12.04.01/**specialpurpose/ecommerce/**webapp/ecommerce/cart/*
> *minipromotext.ftl
>
> Further I could add some non-existing UiLabels for German to/for eCommerce.
> (in case you are interested)
>
> regards, Mark
>
> --
> [hidden email]
>
> http://rsync.it-**infrastrukturen.org<http://rsync.it-infrastrukturen.org>
>
>


--
Regards,
Varun Bhansaly
Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Mark Schneider
Thank you. I have created new issue (as below)

              Summary: Common look for subscreens of ecommerce (minipromotext.ftl )
                  Key: OFBIZ-5173
                  URL:https://issues.apache.org/jira/browse/OFBIZ-5173

I didn't find any possiblity in JIRA  to attach a patch as attachment.


Am 08.04.2013 03:27, schrieb Varun Bhansaly:

> The best way to contribute is by creating a JIRA issue and attaching
> patches therein, this link
> https://cwiki.apache.org/OFBADMIN/ofbiz-contributors-best-practices.html
>   should help.
>
>
> On Sun, Apr 7, 2013 at 9:38 PM, Mark Schneider<[hidden email]>wrote:
>
>> Are you interested in some cosmetic pachtes like the one attached?
>> (to get more common look for all subscreens of ecommerce)
>>
>> apache-ofbiz-12.04.01/**specialpurpose/ecommerce/**webapp/ecommerce/cart/*
>> *minipromotext.ftl
>>
>> Further I could add some non-existing UiLabels for German to/for eCommerce.
>> (in case you are interested)
regards, Mark

--
[hidden email]

http://rsync.it-infrastrukturen.org


minipromotext.ftl.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Aditya Barve
Hello Mark,

Please follow below steps to attach your patch.

#1 Hit :
https://issues.apache.org/jira/browse/OFBIZ-5173?page=com.atlassian.streams.streams-jira-plugin:activity-stream-issue-tab 
<https://issues.apache.org/jira/browse/OFBIZ-5173?page=com.atlassian.streams.streams-jira-plugin:activity-stream-issue-tab>as
logged in user.

#2 Navigate to More Actions > Attach Files.

--
Kind Regards,
Aditya Barve
HotWax Media Pvt. Ltd.
http://www.hotwaxmedia.com/


On 04/08/2013 10:26 AM, Mark Schneider wrote:

> Thank you. I have created new issue (as below)
>
>              Summary: Common look for subscreens of ecommerce
> (minipromotext.ftl )
>                  Key: OFBIZ-5173
>                  URL:https://issues.apache.org/jira/browse/OFBIZ-5173
>
> I didn't find any possiblity in JIRA  to attach a patch as attachment.
>
>
> Am 08.04.2013 03:27, schrieb Varun Bhansaly:
>> The best way to contribute is by creating a JIRA issue and attaching
>> patches therein, this link
>> https://cwiki.apache.org/OFBADMIN/ofbiz-contributors-best-practices.html
>>   should help.
>>
>>
>> On Sun, Apr 7, 2013 at 9:38 PM, Mark
>> Schneider<[hidden email]>wrote:
>>
>>> Are you interested in some cosmetic pachtes like the one attached?
>>> (to get more common look for all subscreens of ecommerce)
>>>
>>> apache-ofbiz-12.04.01/**specialpurpose/ecommerce/**webapp/ecommerce/cart/*
>>>
>>> *minipromotext.ftl
>>>
>>> Further I could add some non-existing UiLabels for German to/for
>>> eCommerce.
>>> (in case you are interested)
>
> regards, Mark
>


Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Christian Geisert
In reply to this post by Mark Schneider
Am 07.04.2013 18:08, schrieb Mark Schneider:

> Hello,
>
> Are you interested in some cosmetic pachtes like the one attached?
> (to get more common look for all subscreens of ecommerce)
>
> apache-ofbiz-12.04.01/specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl
>
>
> Further I could add some non-existing UiLabels for German to/for eCommerce.
> (in case you are interested)

Absolutely ;-)

Christian


Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Mark Schneider
Am 08.04.2013 22:13, schrieb Christian Geisert:

> Am 07.04.2013 18:08, schrieb Mark Schneider:
>> Hello,
>>
>> Are you interested in some cosmetic pachtes like the one attached?
>> (to get more common look for all subscreens of ecommerce)
>>
>> apache-ofbiz-12.04.01/specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl
>>
>>
>>
>> Further I could add some non-existing UiLabels for German to/for
>> eCommerce.
>> (in case you are interested)
>
> Absolutely ;-)
It looks like there is some need for cleaning action in eCommerce for
all languages:


apache-ofbiz-12.04.01-orig/specialpurpose/ecommerce/config$
awk -F\" '/lang=\"/ {print $2}' EcommerceUiLabels.xml | sort -u | \
xargs -iX awk '/lang=\"X/ { X_count +=  1 };  END {print "lang_X
UiLabels\t= " X_count; }' EcommerceUiLabels.xml

lang_ar UiLabels        = 1
lang_cs UiLabels        = 63
lang_da UiLabels        = 291
lang_de UiLabels        = 267
lang_en UiLabels        = 326
lang_en_GB UiLabels     = 11
lang_es UiLabels        = 210
lang_fr UiLabels        = 301
lang_hi_IN UiLabels     = 191
lang_it UiLabels        = 297
lang_ja UiLabels        = 198
lang_nl UiLabels        = 293
lang_pt UiLabels        = 351
lang_pt_BR UiLabels     = 293
lang_pt_PT UiLabels     = 57
lang_ro UiLabels        = 227
lang_ru UiLabels        = 230
lang_th UiLabels        = 248
lang_vi UiLabels        = 315
lang_zh UiLabels        = 589
lang_zh_TW UiLabels     = 298

Not only in eCommerce (s. attached file UiLabels_overview.txt)
apache-ofbiz-12.04.01-orig$
for Y in `find ./ -name "*UiLabel*"`; do echo -e "\n$Y"; awk -F\"
'/lang=\"/ {print $2}' $Y | sort -u | xargs -iX awk '/lang=\"X/ {
X_count +=  1 };  END {print "lang_X UiLabels\t= " X_count; }' $Y; done
 > /tmp/UiLabels_overview.txt

There are also some typos like:
hi-IN
pt-PT
zh-CN
zh-TW

Do you think I should open some JIRA issues? .. eg. like one per component.

Who can help to unify all these UiLabels? ;)

regards, Mark

--
[hidden email]

http://rsync.it-infrastrukturen.org


UiLabels_overview.txt (15K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Jacques Le Roux
Administrator
What do you intend to do exactly?

BTW, no needs to broadcast to the 2 MLs. For such cases dev is enough.

Thanks

Jacques

From: "Mark Schneider" <[hidden email]>

> Am 08.04.2013 22:13, schrieb Christian Geisert:
>> Am 07.04.2013 18:08, schrieb Mark Schneider:
>>> Hello,
>>>
>>> Are you interested in some cosmetic pachtes like the one attached?
>>> (to get more common look for all subscreens of ecommerce)
>>>
>>> apache-ofbiz-12.04.01/specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl
>>>
>>>
>>>
>>> Further I could add some non-existing UiLabels for German to/for
>>> eCommerce.
>>> (in case you are interested)
>>
>> Absolutely ;-)
>
> It looks like there is some need for cleaning action in eCommerce for
> all languages:
>
>
> apache-ofbiz-12.04.01-orig/specialpurpose/ecommerce/config$
> awk -F\" '/lang=\"/ {print $2}' EcommerceUiLabels.xml | sort -u | \
> xargs -iX awk '/lang=\"X/ { X_count +=  1 };  END {print "lang_X
> UiLabels\t= " X_count; }' EcommerceUiLabels.xml
>
> lang_ar UiLabels        = 1
> lang_cs UiLabels        = 63
> lang_da UiLabels        = 291
> lang_de UiLabels        = 267
> lang_en UiLabels        = 326
> lang_en_GB UiLabels     = 11
> lang_es UiLabels        = 210
> lang_fr UiLabels        = 301
> lang_hi_IN UiLabels     = 191
> lang_it UiLabels        = 297
> lang_ja UiLabels        = 198
> lang_nl UiLabels        = 293
> lang_pt UiLabels        = 351
> lang_pt_BR UiLabels     = 293
> lang_pt_PT UiLabels     = 57
> lang_ro UiLabels        = 227
> lang_ru UiLabels        = 230
> lang_th UiLabels        = 248
> lang_vi UiLabels        = 315
> lang_zh UiLabels        = 589
> lang_zh_TW UiLabels     = 298
>
> Not only in eCommerce (s. attached file UiLabels_overview.txt)
> apache-ofbiz-12.04.01-orig$
> for Y in `find ./ -name "*UiLabel*"`; do echo -e "\n$Y"; awk -F\"
> '/lang=\"/ {print $2}' $Y | sort -u | xargs -iX awk '/lang=\"X/ {
> X_count +=  1 };  END {print "lang_X UiLabels\t= " X_count; }' $Y; done
> > /tmp/UiLabels_overview.txt
>
> There are also some typos like:
> hi-IN
> pt-PT
> zh-CN
> zh-TW
>
> Do you think I should open some JIRA issues? .. eg. like one per component.
>
> Who can help to unify all these UiLabels? ;)
>
> regards, Mark
>
> --
> [hidden email]
>
> http://rsync.it-infrastrukturen.org
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Atul Vani
In reply to this post by Mark Schneider
Here are stats for all the components:
index lang count
0 en 12132
1 it 10893
2   zh 10245
3 fr 9821
4 zh_TW 8804
5 th 8063
6 de 7916
7 es 6655
8 ro 6075
9 ru 5283
10 nl 4553
11 pt_BR 4226
12 hi_IN 3275
13 pt 3014
14 vi 1674
15 ar 1243
16 da 803
17 zh_CN 795
18 pt_PT 623
19 ja 596
20 cs 441
21 de_CH 71
22 en_GB 62
23 fy 3
24 hi-IN 2
26 FR 1
27 in 1
28 pt-PT 1
29 zh-CN 1
30 zh-TW 1

Can't we remove a few from the bottom?

On Wed, 10 Apr 2013 08:08:56 +0530, Jacques Le Roux  
<[hidden email]> wrote:

> What do you intend to do exactly?
>
> BTW, no needs to broadcast to the 2 MLs. For such cases dev is enough.
>
> Thanks
>
> Jacques
>
> From: "Mark Schneider" <[hidden email]>
>> Am 08.04.2013 22:13, schrieb Christian Geisert:
>>> Am 07.04.2013 18:08, schrieb Mark Schneider:
>>>> Hello,
>>>>
>>>> Are you interested in some cosmetic pachtes like the one attached?
>>>> (to get more common look for all subscreens of ecommerce)
>>>>
>>>> apache-ofbiz-12.04.01/specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl
>>>>
>>>>
>>>>
>>>> Further I could add some non-existing UiLabels for German to/for
>>>> eCommerce.
>>>> (in case you are interested)
>>>
>>> Absolutely ;-)
>>
>> It looks like there is some need for cleaning action in eCommerce for
>> all languages:
>>
>>
>> apache-ofbiz-12.04.01-orig/specialpurpose/ecommerce/config$
>> awk -F\" '/lang=\"/ {print $2}' EcommerceUiLabels.xml | sort -u | \
>> xargs -iX awk '/lang=\"X/ { X_count +=  1 };  END {print "lang_X
>> UiLabels\t= " X_count; }' EcommerceUiLabels.xml
>>
>> lang_ar UiLabels        = 1
>> lang_cs UiLabels        = 63
>> lang_da UiLabels        = 291
>> lang_de UiLabels        = 267
>> lang_en UiLabels        = 326
>> lang_en_GB UiLabels     = 11
>> lang_es UiLabels        = 210
>> lang_fr UiLabels        = 301
>> lang_hi_IN UiLabels     = 191
>> lang_it UiLabels        = 297
>> lang_ja UiLabels        = 198
>> lang_nl UiLabels        = 293
>> lang_pt UiLabels        = 351
>> lang_pt_BR UiLabels     = 293
>> lang_pt_PT UiLabels     = 57
>> lang_ro UiLabels        = 227
>> lang_ru UiLabels        = 230
>> lang_th UiLabels        = 248
>> lang_vi UiLabels        = 315
>> lang_zh UiLabels        = 589
>> lang_zh_TW UiLabels     = 298
>>
>> Not only in eCommerce (s. attached file UiLabels_overview.txt)
>> apache-ofbiz-12.04.01-orig$
>> for Y in `find ./ -name "*UiLabel*"`; do echo -e "\n$Y"; awk -F\"
>> '/lang=\"/ {print $2}' $Y | sort -u | xargs -iX awk '/lang=\"X/ {
>> X_count +=  1 };  END {print "lang_X UiLabels\t= " X_count; }' $Y; done
>> > /tmp/UiLabels_overview.txt
>>
>> There are also some typos like:
>> hi-IN
>> pt-PT
>> zh-CN
>> zh-TW
>>
>> Do you think I should open some JIRA issues? .. eg. like one per  
>> component.
>>
>> Who can help to unify all these UiLabels? ;)
>>
>> regards, Mark
>>
>> --
>> [hidden email]
>>
>> http://rsync.it-infrastrukturen.org
>>
>>


--
Using Opera's revolutionary email client: http://www.opera.com/mail/
Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Mark Schneider
In reply to this post by Jacques Le Roux
Am 10.04.2013 04:38, schrieb Jacques Le Roux:
> What do you intend to do exactly?
In first step I would add "missing" lang entries for German
(eCommerce component) and add a patch to JIRA issue.
I guess that the number of lang etntries for every particular language
should be the same for all languages.
(maybe with some exceptions like for eg. for de_DE, de_CH etc.
Both are German but may be country specific)

For minipromotext.ftl I have attached a patch already to the JIRA issue.
I have notice that the "older" demo shop (link on the OFBiz site) seems
to have such patch already.

> BTW, no needs to broadcast to the 2 MLs. For such cases dev is enough.
Thank you for the hint and sorry .. I did it to involve also OFBiz users
as not all of them are on dev ML.
Do you think that new JIRA entries (one for every OFBiz comonent)
are most comfortable for devs?

regards, Mark

--
[hidden email]

http://rsync.it-infrastrukturen.org


> Thanks
>
> Jacques
>
> From: "Mark Schneider"<[hidden email]>
>> Am 08.04.2013 22:13, schrieb Christian Geisert:
>>> Am 07.04.2013 18:08, schrieb Mark Schneider:
>>>> Hello,
>>>>
>>>> Are you interested in some cosmetic pachtes like the one attached?
>>>> (to get more common look for all subscreens of ecommerce)
>>>>
>>>> apache-ofbiz-12.04.01/specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl
>>>>
>>>>
>>>>
>>>> Further I could add some non-existing UiLabels for German to/for
>>>> eCommerce.
>>>> (in case you are interested)
>>> Absolutely ;-)
>> It looks like there is some need for cleaning action in eCommerce for
>> all languages:
>>
>>
>> apache-ofbiz-12.04.01-orig/specialpurpose/ecommerce/config$
>> awk -F\" '/lang=\"/ {print $2}' EcommerceUiLabels.xml | sort -u | \
>> xargs -iX awk '/lang=\"X/ { X_count +=  1 };  END {print "lang_X
>> UiLabels\t= " X_count; }' EcommerceUiLabels.xml
>>
>> lang_ar UiLabels        = 1
>> lang_cs UiLabels        = 63
>> lang_da UiLabels        = 291
>> lang_de UiLabels        = 267
>> lang_en UiLabels        = 326
>> lang_en_GB UiLabels     = 11
>> lang_es UiLabels        = 210
>> lang_fr UiLabels        = 301
>> lang_hi_IN UiLabels     = 191
>> lang_it UiLabels        = 297
>> lang_ja UiLabels        = 198
>> lang_nl UiLabels        = 293
>> lang_pt UiLabels        = 351
>> lang_pt_BR UiLabels     = 293
>> lang_pt_PT UiLabels     = 57
>> lang_ro UiLabels        = 227
>> lang_ru UiLabels        = 230
>> lang_th UiLabels        = 248
>> lang_vi UiLabels        = 315
>> lang_zh UiLabels        = 589
>> lang_zh_TW UiLabels     = 298
>>
>> Not only in eCommerce (s. attached file UiLabels_overview.txt)
>> apache-ofbiz-12.04.01-orig$
>> for Y in `find ./ -name "*UiLabel*"`; do echo -e "\n$Y"; awk -F\"
>> '/lang=\"/ {print $2}' $Y | sort -u | xargs -iX awk '/lang=\"X/ {
>> X_count +=  1 };  END {print "lang_X UiLabels\t= " X_count; }' $Y; done
>>> /tmp/UiLabels_overview.txt
>> There are also some typos like:
>> hi-IN
>> pt-PT
>> zh-CN
>> zh-TW
>>
>> Do you think I should open some JIRA issues? .. eg. like one per component.
>>
>> Who can help to unify all these UiLabels? ;)
Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Jacques Le Roux
Administrator
In reply to this post by Atul Vani
Thanks Atul,

Done for the 1 FR at r1466837
> 26 FR 1

To be continued, I propose to create a JIra

Jacques

From: "Atul Vani" <[hidden email]>

> Here are stats for all the components:
> index lang count
> 0 en 12132
> 1 it 10893
> 2   zh 10245
> 3 fr 9821
> 4 zh_TW 8804
> 5 th 8063
> 6 de 7916
> 7 es 6655
> 8 ro 6075
> 9 ru 5283
> 10 nl 4553
> 11 pt_BR 4226
> 12 hi_IN 3275
> 13 pt 3014
> 14 vi 1674
> 15 ar 1243
> 16 da 803
> 17 zh_CN 795
> 18 pt_PT 623
> 19 ja 596
> 20 cs 441
> 21 de_CH 71
> 22 en_GB 62
> 23 fy 3
> 24 hi-IN 2
> 26 FR 1
> 27 in 1
> 28 pt-PT 1
> 29 zh-CN 1
> 30 zh-TW 1
>
> Can't we remove a few from the bottom?
>
> On Wed, 10 Apr 2013 08:08:56 +0530, Jacques Le Roux  
> <[hidden email]> wrote:
>
>> What do you intend to do exactly?
>>
>> BTW, no needs to broadcast to the 2 MLs. For such cases dev is enough.
>>
>> Thanks
>>
>> Jacques
>>
>> From: "Mark Schneider" <[hidden email]>
>>> Am 08.04.2013 22:13, schrieb Christian Geisert:
>>>> Am 07.04.2013 18:08, schrieb Mark Schneider:
>>>>> Hello,
>>>>>
>>>>> Are you interested in some cosmetic pachtes like the one attached?
>>>>> (to get more common look for all subscreens of ecommerce)
>>>>>
>>>>> apache-ofbiz-12.04.01/specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl
>>>>>
>>>>>
>>>>>
>>>>> Further I could add some non-existing UiLabels for German to/for
>>>>> eCommerce.
>>>>> (in case you are interested)
>>>>
>>>> Absolutely ;-)
>>>
>>> It looks like there is some need for cleaning action in eCommerce for
>>> all languages:
>>>
>>>
>>> apache-ofbiz-12.04.01-orig/specialpurpose/ecommerce/config$
>>> awk -F\" '/lang=\"/ {print $2}' EcommerceUiLabels.xml | sort -u | \
>>> xargs -iX awk '/lang=\"X/ { X_count +=  1 };  END {print "lang_X
>>> UiLabels\t= " X_count; }' EcommerceUiLabels.xml
>>>
>>> lang_ar UiLabels        = 1
>>> lang_cs UiLabels        = 63
>>> lang_da UiLabels        = 291
>>> lang_de UiLabels        = 267
>>> lang_en UiLabels        = 326
>>> lang_en_GB UiLabels     = 11
>>> lang_es UiLabels        = 210
>>> lang_fr UiLabels        = 301
>>> lang_hi_IN UiLabels     = 191
>>> lang_it UiLabels        = 297
>>> lang_ja UiLabels        = 198
>>> lang_nl UiLabels        = 293
>>> lang_pt UiLabels        = 351
>>> lang_pt_BR UiLabels     = 293
>>> lang_pt_PT UiLabels     = 57
>>> lang_ro UiLabels        = 227
>>> lang_ru UiLabels        = 230
>>> lang_th UiLabels        = 248
>>> lang_vi UiLabels        = 315
>>> lang_zh UiLabels        = 589
>>> lang_zh_TW UiLabels     = 298
>>>
>>> Not only in eCommerce (s. attached file UiLabels_overview.txt)
>>> apache-ofbiz-12.04.01-orig$
>>> for Y in `find ./ -name "*UiLabel*"`; do echo -e "\n$Y"; awk -F\"
>>> '/lang=\"/ {print $2}' $Y | sort -u | xargs -iX awk '/lang=\"X/ {
>>> X_count +=  1 };  END {print "lang_X UiLabels\t= " X_count; }' $Y; done
>>> > /tmp/UiLabels_overview.txt
>>>
>>> There are also some typos like:
>>> hi-IN
>>> pt-PT
>>> zh-CN
>>> zh-TW
>>>
>>> Do you think I should open some JIRA issues? .. eg. like one per  
>>> component.
>>>
>>> Who can help to unify all these UiLabels? ;)
>>>
>>> regards, Mark
>>>
>>> --
>>> [hidden email]
>>>
>>> http://rsync.it-infrastrukturen.org
>>>
>>>
>
>
> --
> Using Opera's revolutionary email client: http://www.opera.com/mail/
Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Jacques Le Roux
Administrator
In reply to this post by Mark Schneider
From: "Mark Schneider" <[hidden email]>
> Am 10.04.2013 04:38, schrieb Jacques Le Roux:
>> What do you intend to do exactly?
> In first step I would add "missing" lang entries for German
> (eCommerce component) and add a patch to JIRA issue.

Great, looking forward

> I guess that the number of lang etntries for every particular language
> should be the same for all languages.
> (maybe with some exceptions like for eg. for de_DE, de_CH etc.
> Both are German but may be country specific)

Yes it's a matter of human ressources and will...
Also there are also shared resources in wiki
https://cwiki.apache.org/confluence/display/OFBIZ/Dictionary+for+translations+to+German
https://cwiki.apache.org/confluence/display/OFBIZ/Dictionary+for+French+translations
https://cwiki.apache.org/confluence/display/OFBIZ/Dictionary+for+Danish+translations
https://cwiki.apache.org/confluence/display/OFBIZ/Dictionary+for+Dutch+translations
Not all are yet referred from https://cwiki.apache.org/confluence/display/OFBIZ/Misc+Pages+-+Technical
Though ratehr a main page for dictionaries would be welcome and referred from there

Also
https://cwiki.apache.org/confluence/display/OFBIZ/Guide+to+OFBiz-i18n%2C++Internationalisation+of+OFBiz

HTH

Jacques

> For minipromotext.ftl I have attached a patch already to the JIRA issue.
> I have notice that the "older" demo shop (link on the OFBiz site) seems
> to have such patch already.
>
>> BTW, no needs to broadcast to the 2 MLs. For such cases dev is enough.
> Thank you for the hint and sorry .. I did it to involve also OFBiz users
> as not all of them are on dev ML.
> Do you think that new JIRA entries (one for every OFBiz comonent)
> are most comfortable for devs?
>
> regards, Mark
>
> --
> [hidden email]
>
> http://rsync.it-infrastrukturen.org
>
>
>> Thanks
>>
>> Jacques
>>
>> From: "Mark Schneider"<[hidden email]>
>>> Am 08.04.2013 22:13, schrieb Christian Geisert:
>>>> Am 07.04.2013 18:08, schrieb Mark Schneider:
>>>>> Hello,
>>>>>
>>>>> Are you interested in some cosmetic pachtes like the one attached?
>>>>> (to get more common look for all subscreens of ecommerce)
>>>>>
>>>>> apache-ofbiz-12.04.01/specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl
>>>>>
>>>>>
>>>>>
>>>>> Further I could add some non-existing UiLabels for German to/for
>>>>> eCommerce.
>>>>> (in case you are interested)
>>>> Absolutely ;-)
>>> It looks like there is some need for cleaning action in eCommerce for
>>> all languages:
>>>
>>>
>>> apache-ofbiz-12.04.01-orig/specialpurpose/ecommerce/config$
>>> awk -F\" '/lang=\"/ {print $2}' EcommerceUiLabels.xml | sort -u | \
>>> xargs -iX awk '/lang=\"X/ { X_count +=  1 };  END {print "lang_X
>>> UiLabels\t= " X_count; }' EcommerceUiLabels.xml
>>>
>>> lang_ar UiLabels        = 1
>>> lang_cs UiLabels        = 63
>>> lang_da UiLabels        = 291
>>> lang_de UiLabels        = 267
>>> lang_en UiLabels        = 326
>>> lang_en_GB UiLabels     = 11
>>> lang_es UiLabels        = 210
>>> lang_fr UiLabels        = 301
>>> lang_hi_IN UiLabels     = 191
>>> lang_it UiLabels        = 297
>>> lang_ja UiLabels        = 198
>>> lang_nl UiLabels        = 293
>>> lang_pt UiLabels        = 351
>>> lang_pt_BR UiLabels     = 293
>>> lang_pt_PT UiLabels     = 57
>>> lang_ro UiLabels        = 227
>>> lang_ru UiLabels        = 230
>>> lang_th UiLabels        = 248
>>> lang_vi UiLabels        = 315
>>> lang_zh UiLabels        = 589
>>> lang_zh_TW UiLabels     = 298
>>>
>>> Not only in eCommerce (s. attached file UiLabels_overview.txt)
>>> apache-ofbiz-12.04.01-orig$
>>> for Y in `find ./ -name "*UiLabel*"`; do echo -e "\n$Y"; awk -F\"
>>> '/lang=\"/ {print $2}' $Y | sort -u | xargs -iX awk '/lang=\"X/ {
>>> X_count +=  1 };  END {print "lang_X UiLabels\t= " X_count; }' $Y; done
>>>> /tmp/UiLabels_overview.txt
>>> There are also some typos like:
>>> hi-IN
>>> pt-PT
>>> zh-CN
>>> zh-TW
>>>
>>> Do you think I should open some JIRA issues? .. eg. like one per component.
>>>
>>> Who can help to unify all these UiLabels? ;)
Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Atul Vani
In reply to this post by Mark Schneider
Thanks Jacques, here's the JIRA issue:  OFBIZ-5177 - Cleanup UI Labels for  
languages which aren't well supported

If the community agrees for a couple of the languages, I can provide  
patches for them.

On Thu, 11 Apr 2013 16:52:17 +0530, Jacques Le Roux  
<[hidden email]> wrote:

> Thanks Atul,
>
> Done for the 1 FR at r1466837
>> 26 FR 1
>
> To be continued, I propose to create a JIra
>
> Jacques
>
> From: "Atul Vani" <[hidden email]>
>> Here are stats for all the components:
>> index lang count
>> 0 en 12132
>> 1 it 10893
>> 2   zh 10245
>> 3 fr 9821
>> 4 zh_TW 8804
>> 5 th 8063
>> 6 de 7916
>> 7 es 6655
>> 8 ro 6075
>> 9 ru 5283
>> 10 nl 4553
>> 11 pt_BR 4226
>> 12 hi_IN 3275
>> 13 pt 3014
>> 14 vi 1674
>> 15 ar 1243
>> 16 da 803
>> 17 zh_CN 795
>> 18 pt_PT 623
>> 19 ja 596
>> 20 cs 441
>> 21 de_CH 71
>> 22 en_GB 62
>> 23 fy 3
>> 24 hi-IN 2
>> 26 FR 1
>> 27 in 1
>> 28 pt-PT 1
>> 29 zh-CN 1
>> 30 zh-TW 1
>>
>> Can't we remove a few from the bottom?
>>
>> On Wed, 10 Apr 2013 08:08:56 +0530, Jacques Le Roux
>> <[hidden email]> wrote:
>>
>>> What do you intend to do exactly?
>>>
>>> BTW, no needs to broadcast to the 2 MLs. For such cases dev is enough.
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>> From: "Mark Schneider" <[hidden email]>
>>>> Am 08.04.2013 22:13, schrieb Christian Geisert:
>>>>> Am 07.04.2013 18:08, schrieb Mark Schneider:
>>>>>> Hello,
>>>>>>
>>>>>> Are you interested in some cosmetic pachtes like the one attached?
>>>>>> (to get more common look for all subscreens of ecommerce)
>>>>>>
>>>>>> apache-ofbiz-12.04.01/specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl
>>>>>>
>>>>>>
>>>>>>
>>>>>> Further I could add some non-existing UiLabels for German to/for
>>>>>> eCommerce.
>>>>>> (in case you are interested)
>>>>>
>>>>> Absolutely ;-)
>>>>
>>>> It looks like there is some need for cleaning action in eCommerce for
>>>> all languages:
>>>>
>>>>
>>>> apache-ofbiz-12.04.01-orig/specialpurpose/ecommerce/config$
>>>> awk -F\" '/lang=\"/ {print $2}' EcommerceUiLabels.xml | sort -u | \
>>>> xargs -iX awk '/lang=\"X/ { X_count +=  1 };  END {print "lang_X
>>>> UiLabels\t= " X_count; }' EcommerceUiLabels.xml
>>>>
>>>> lang_ar UiLabels        = 1
>>>> lang_cs UiLabels        = 63
>>>> lang_da UiLabels        = 291
>>>> lang_de UiLabels        = 267
>>>> lang_en UiLabels        = 326
>>>> lang_en_GB UiLabels     = 11
>>>> lang_es UiLabels        = 210
>>>> lang_fr UiLabels        = 301
>>>> lang_hi_IN UiLabels     = 191
>>>> lang_it UiLabels        = 297
>>>> lang_ja UiLabels        = 198
>>>> lang_nl UiLabels        = 293
>>>> lang_pt UiLabels        = 351
>>>> lang_pt_BR UiLabels     = 293
>>>> lang_pt_PT UiLabels     = 57
>>>> lang_ro UiLabels        = 227
>>>> lang_ru UiLabels        = 230
>>>> lang_th UiLabels        = 248
>>>> lang_vi UiLabels        = 315
>>>> lang_zh UiLabels        = 589
>>>> lang_zh_TW UiLabels     = 298
>>>>
>>>> Not only in eCommerce (s. attached file UiLabels_overview.txt)
>>>> apache-ofbiz-12.04.01-orig$
>>>> for Y in `find ./ -name "*UiLabel*"`; do echo -e "\n$Y"; awk -F\"
>>>> '/lang=\"/ {print $2}' $Y | sort -u | xargs -iX awk '/lang=\"X/ {
>>>> X_count +=  1 };  END {print "lang_X UiLabels\t= " X_count; }' $Y;  
>>>> done
>>>> > /tmp/UiLabels_overview.txt
>>>>
>>>> There are also some typos like:
>>>> hi-IN
>>>> pt-PT
>>>> zh-CN
>>>> zh-TW
>>>>
>>>> Do you think I should open some JIRA issues? .. eg. like one per
>>>> component.
>>>>
>>>> Who can help to unify all these UiLabels? ;)
>>>>
>>>> regards, Mark
>>>>
>>>> --
>>>> [hidden email]
>>>>
>>>> http://rsync.it-infrastrukturen.org
>>>>
>>>>
>>
>>
>> --
>> Using Opera's revolutionary email client: http://www.opera.com/mail/


--
Using Opera's revolutionary email client: http://www.opera.com/mail/
Reply | Threaded
Open this post in threaded view
|

Re: Cosmetic patch for specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl

Jacques Le Roux
Administrator
Yes please do Atul

Thanks

Jacques

From: "Atul Vani" <[hidden email]>

> Thanks Jacques, here's the JIRA issue:  OFBIZ-5177 - Cleanup UI Labels for  
> languages which aren't well supported
>
> If the community agrees for a couple of the languages, I can provide  
> patches for them.
>
> On Thu, 11 Apr 2013 16:52:17 +0530, Jacques Le Roux  
> <[hidden email]> wrote:
>
>> Thanks Atul,
>>
>> Done for the 1 FR at r1466837
>>> 26 FR 1
>>
>> To be continued, I propose to create a JIra
>>
>> Jacques
>>
>> From: "Atul Vani" <[hidden email]>
>>> Here are stats for all the components:
>>> index lang count
>>> 0 en 12132
>>> 1 it 10893
>>> 2   zh 10245
>>> 3 fr 9821
>>> 4 zh_TW 8804
>>> 5 th 8063
>>> 6 de 7916
>>> 7 es 6655
>>> 8 ro 6075
>>> 9 ru 5283
>>> 10 nl 4553
>>> 11 pt_BR 4226
>>> 12 hi_IN 3275
>>> 13 pt 3014
>>> 14 vi 1674
>>> 15 ar 1243
>>> 16 da 803
>>> 17 zh_CN 795
>>> 18 pt_PT 623
>>> 19 ja 596
>>> 20 cs 441
>>> 21 de_CH 71
>>> 22 en_GB 62
>>> 23 fy 3
>>> 24 hi-IN 2
>>> 26 FR 1
>>> 27 in 1
>>> 28 pt-PT 1
>>> 29 zh-CN 1
>>> 30 zh-TW 1
>>>
>>> Can't we remove a few from the bottom?
>>>
>>> On Wed, 10 Apr 2013 08:08:56 +0530, Jacques Le Roux
>>> <[hidden email]> wrote:
>>>
>>>> What do you intend to do exactly?
>>>>
>>>> BTW, no needs to broadcast to the 2 MLs. For such cases dev is enough.
>>>>
>>>> Thanks
>>>>
>>>> Jacques
>>>>
>>>> From: "Mark Schneider" <[hidden email]>
>>>>> Am 08.04.2013 22:13, schrieb Christian Geisert:
>>>>>> Am 07.04.2013 18:08, schrieb Mark Schneider:
>>>>>>> Hello,
>>>>>>>
>>>>>>> Are you interested in some cosmetic pachtes like the one attached?
>>>>>>> (to get more common look for all subscreens of ecommerce)
>>>>>>>
>>>>>>> apache-ofbiz-12.04.01/specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Further I could add some non-existing UiLabels for German to/for
>>>>>>> eCommerce.
>>>>>>> (in case you are interested)
>>>>>>
>>>>>> Absolutely ;-)
>>>>>
>>>>> It looks like there is some need for cleaning action in eCommerce for
>>>>> all languages:
>>>>>
>>>>>
>>>>> apache-ofbiz-12.04.01-orig/specialpurpose/ecommerce/config$
>>>>> awk -F\" '/lang=\"/ {print $2}' EcommerceUiLabels.xml | sort -u | \
>>>>> xargs -iX awk '/lang=\"X/ { X_count +=  1 };  END {print "lang_X
>>>>> UiLabels\t= " X_count; }' EcommerceUiLabels.xml
>>>>>
>>>>> lang_ar UiLabels        = 1
>>>>> lang_cs UiLabels        = 63
>>>>> lang_da UiLabels        = 291
>>>>> lang_de UiLabels        = 267
>>>>> lang_en UiLabels        = 326
>>>>> lang_en_GB UiLabels     = 11
>>>>> lang_es UiLabels        = 210
>>>>> lang_fr UiLabels        = 301
>>>>> lang_hi_IN UiLabels     = 191
>>>>> lang_it UiLabels        = 297
>>>>> lang_ja UiLabels        = 198
>>>>> lang_nl UiLabels        = 293
>>>>> lang_pt UiLabels        = 351
>>>>> lang_pt_BR UiLabels     = 293
>>>>> lang_pt_PT UiLabels     = 57
>>>>> lang_ro UiLabels        = 227
>>>>> lang_ru UiLabels        = 230
>>>>> lang_th UiLabels        = 248
>>>>> lang_vi UiLabels        = 315
>>>>> lang_zh UiLabels        = 589
>>>>> lang_zh_TW UiLabels     = 298
>>>>>
>>>>> Not only in eCommerce (s. attached file UiLabels_overview.txt)
>>>>> apache-ofbiz-12.04.01-orig$
>>>>> for Y in `find ./ -name "*UiLabel*"`; do echo -e "\n$Y"; awk -F\"
>>>>> '/lang=\"/ {print $2}' $Y | sort -u | xargs -iX awk '/lang=\"X/ {
>>>>> X_count +=  1 };  END {print "lang_X UiLabels\t= " X_count; }' $Y;  
>>>>> done
>>>>> > /tmp/UiLabels_overview.txt
>>>>>
>>>>> There are also some typos like:
>>>>> hi-IN
>>>>> pt-PT
>>>>> zh-CN
>>>>> zh-TW
>>>>>
>>>>> Do you think I should open some JIRA issues? .. eg. like one per
>>>>> component.
>>>>>
>>>>> Who can help to unify all these UiLabels? ;)
>>>>>
>>>>> regards, Mark
>>>>>
>>>>> --
>>>>> [hidden email]
>>>>>
>>>>> http://rsync.it-infrastrukturen.org
>>>>>
>>>>>
>>>
>>>
>>> --
>>> Using Opera's revolutionary email client: http://www.opera.com/mail/
>
>
> --
> Using Opera's revolutionary email client: http://www.opera.com/mail/