Compiler warnings in trunk

[Erwan de FERRIERES-3]

Hi all,

there is still some compiler warnings in the trunk.

I've list those files with calls to deprecated methods :
* OFBizBirtViewerReportService.java (call to a
org.eclipse.birt.report.service.ReportEngineService.DummyRemoteException
which is deprecated)
* UtilXml.java (this import : org.apache.xml.serialize.OutputFormat is
deprecated)
* JSONSimpleEventHandler.java (the AbstractJSONEventHandler has been
deprecated).
* and others due to TimeOfDayRange which has also been deprecated.

If someone could have a look to those, it would be fine.

Thanks,

--
Erwan de FERRIERES
www.nereide.biz

[Scott Gray-2]

On 22/01/2010, at 8:03 AM, Erwan de FERRIERES wrote:

> Hi all,
>
> there is still some compiler warnings in the trunk.
>
> I've list those files with calls to deprecated methods :
> * OFBizBirtViewerReportService.java (call to a org.eclipse.birt.report.service.ReportEngineService.DummyRemoteException which is deprecated)
> * UtilXml.java (this import : org.apache.xml.serialize.OutputFormat is deprecated)
> * JSONSimpleEventHandler.java (the AbstractJSONEventHandler has been deprecated).

I couldn't seem to disable this warning regardless of where I put the suppress warnings annotation, if anyone has some pointers I'll be glad to hear them.

> * and others due to TimeOfDayRange which has also been deprecated.
>
> If someone could have a look to those, it would be fine.
>
> Thanks,
>
> --
> Erwan de FERRIERES
> www.nereide.biz

[Adrian Crum]

Scott Gray wrote:

> On 22/01/2010, at 8:03 AM, Erwan de FERRIERES wrote:
>
>> Hi all,
>>
>> there is still some compiler warnings in the trunk.
>>
>> I've list those files with calls to deprecated methods :
>> * OFBizBirtViewerReportService.java (call to a org.eclipse.birt.report.service.ReportEngineService.DummyRemoteException which is deprecated)
>> * UtilXml.java (this import : org.apache.xml.serialize.OutputFormat is deprecated)
>> * JSONSimpleEventHandler.java (the AbstractJSONEventHandler has been deprecated).
>
> I couldn't seem to disable this warning regardless of where I put the suppress warnings annotation, if anyone has some pointers I'll be glad to hear them.

I think it is safe to remove the deprecated class from UtilXml now. The
method that uses it has been deprecated for nearly a year now.

-Adrian

[Adam Heath-2]

Adrian Crum wrote:

> Scott Gray wrote:
>> On 22/01/2010, at 8:03 AM, Erwan de FERRIERES wrote:
>>
>>> Hi all,
>>>
>>> there is still some compiler warnings in the trunk.
>>>
>>> I've list those files with calls to deprecated methods :
>>> * OFBizBirtViewerReportService.java (call to a
>>> org.eclipse.birt.report.service.ReportEngineService.DummyRemoteException
>>> which is deprecated)
>>> * UtilXml.java (this import : org.apache.xml.serialize.OutputFormat
>>> is deprecated)
>>> * JSONSimpleEventHandler.java (the AbstractJSONEventHandler has been
>>> deprecated).
>>
>> I couldn't seem to disable this warning regardless of where I put the
>> suppress warnings annotation, if anyone has some pointers I'll be glad
>> to hear them.
>
> I think it is safe to remove the deprecated class from UtilXml now. The
> method that uses it has been deprecated for nearly a year now.

Is it in a release?

[Adrian Crum]

Adam Heath wrote:

> Adrian Crum wrote:
>> Scott Gray wrote:
>>> On 22/01/2010, at 8:03 AM, Erwan de FERRIERES wrote:
>>>
>>>> Hi all,
>>>>
>>>> there is still some compiler warnings in the trunk.
>>>>
>>>> I've list those files with calls to deprecated methods :
>>>> * OFBizBirtViewerReportService.java (call to a
>>>> org.eclipse.birt.report.service.ReportEngineService.DummyRemoteException
>>>> which is deprecated)
>>>> * UtilXml.java (this import : org.apache.xml.serialize.OutputFormat
>>>> is deprecated)
>>>> * JSONSimpleEventHandler.java (the AbstractJSONEventHandler has been
>>>> deprecated).
>>> I couldn't seem to disable this warning regardless of where I put the
>>> suppress warnings annotation, if anyone has some pointers I'll be glad
>>> to hear them.
>> I think it is safe to remove the deprecated class from UtilXml now. The
>> method that uses it has been deprecated for nearly a year now.
>
> Is it in a release?

Yes.

[Adam Heath-2]

Adrian Crum wrote:

> Adam Heath wrote:
>> Adrian Crum wrote:
>>> Scott Gray wrote:
>>>> On 22/01/2010, at 8:03 AM, Erwan de FERRIERES wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> there is still some compiler warnings in the trunk.
>>>>>
>>>>> I've list those files with calls to deprecated methods :
>>>>> * OFBizBirtViewerReportService.java (call to a
>>>>> org.eclipse.birt.report.service.ReportEngineService.DummyRemoteException
>>>>>
>>>>> which is deprecated)
>>>>> * UtilXml.java (this import : org.apache.xml.serialize.OutputFormat
>>>>> is deprecated)
>>>>> * JSONSimpleEventHandler.java (the AbstractJSONEventHandler has been
>>>>> deprecated).
>>>> I couldn't seem to disable this warning regardless of where I put the
>>>> suppress warnings annotation, if anyone has some pointers I'll be glad
>>>> to hear them.
>>> I think it is safe to remove the deprecated class from UtilXml now. The
>>> method that uses it has been deprecated for nearly a year now.
>>
>> Is it in a release?
>
> Yes.

Was it deprecated in the *last* release, or was deprecated added
during *this* development cycle?  If the former, then you can remove
it.  If the latter, it has to stay for the next release.

If I'm causing you(or whoever goes about fixing these) too much work,
then I'm sorry, but this is what is required for proper release
management.

[Adrian Crum]

Adam Heath wrote:

> Adrian Crum wrote:
>> Adam Heath wrote:
>>> Adrian Crum wrote:
>>>> Scott Gray wrote:
>>>>> On 22/01/2010, at 8:03 AM, Erwan de FERRIERES wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> there is still some compiler warnings in the trunk.
>>>>>>
>>>>>> I've list those files with calls to deprecated methods :
>>>>>> * OFBizBirtViewerReportService.java (call to a
>>>>>> org.eclipse.birt.report.service.ReportEngineService.DummyRemoteException
>>>>>>
>>>>>> which is deprecated)
>>>>>> * UtilXml.java (this import : org.apache.xml.serialize.OutputFormat
>>>>>> is deprecated)
>>>>>> * JSONSimpleEventHandler.java (the AbstractJSONEventHandler has been
>>>>>> deprecated).
>>>>> I couldn't seem to disable this warning regardless of where I put the
>>>>> suppress warnings annotation, if anyone has some pointers I'll be glad
>>>>> to hear them.
>>>> I think it is safe to remove the deprecated class from UtilXml now. The
>>>> method that uses it has been deprecated for nearly a year now.
>>> Is it in a release?
>> Yes.
>
> Was it deprecated in the *last* release, or was deprecated added
> during *this* development cycle?  If the former, then you can remove
> it.  If the latter, it has to stay for the next release.
>
> If I'm causing you(or whoever goes about fixing these) too much work,
> then I'm sorry, but this is what is required for proper release
> management.

Understood. It was deprecated after the last release. It isn't causing
anyone too much work - it just produces an annoying compiler warning.

[Scott Gray-2]

On 22/01/2010, at 10:21 AM, Adrian Crum wrote:

> Adam Heath wrote:
>> Adrian Crum wrote:
>>> Adam Heath wrote:
>>>> Adrian Crum wrote:
>>>>> Scott Gray wrote:
>>>>>> On 22/01/2010, at 8:03 AM, Erwan de FERRIERES wrote:
>>>>>>
>>>>>>> Hi all,
>>>>>>>
>>>>>>> there is still some compiler warnings in the trunk.
>>>>>>>
>>>>>>> I've list those files with calls to deprecated methods :
>>>>>>> * OFBizBirtViewerReportService.java (call to a
>>>>>>> org.eclipse.birt.report.service.ReportEngineService.DummyRemoteException
>>>>>>>
>>>>>>> which is deprecated)
>>>>>>> * UtilXml.java (this import : org.apache.xml.serialize.OutputFormat
>>>>>>> is deprecated)
>>>>>>> * JSONSimpleEventHandler.java (the AbstractJSONEventHandler has been
>>>>>>> deprecated).
>>>>>> I couldn't seem to disable this warning regardless of where I put the
>>>>>> suppress warnings annotation, if anyone has some pointers I'll be glad
>>>>>> to hear them.
>>>>> I think it is safe to remove the deprecated class from UtilXml now. The
>>>>> method that uses it has been deprecated for nearly a year now.
>>>> Is it in a release?
>>> Yes.
>> Was it deprecated in the *last* release, or was deprecated added
>> during *this* development cycle?  If the former, then you can remove
>> it.  If the latter, it has to stay for the next release.
>> If I'm causing you(or whoever goes about fixing these) too much work,
>> then I'm sorry, but this is what is required for proper release
>> management.
>
> Understood. It was deprecated after the last release. It isn't causing anyone too much work - it just produces an annoying compiler warning.
>

A good majority of the deprecated methods prior to the last release were deprecated using the javadoc style: /** @deprecated */
I updated them post release to use the actual @Deprecated annotation, any opinions on whether we're okay to remove them now or would we be better to wait?

[Adam Heath-2]

Scott Gray wrote:
> A good majority of the deprecated methods prior to the last release were deprecated using the javadoc style: /** @deprecated */
> I updated them post release to use the actual @Deprecated annotation, any opinions on whether we're okay to remove them now or would we be better to wait?

Does javac warn if only javadoc deprecation is used?

[Scott Gray-2]

On 22/01/2010, at 11:14 AM, Adam Heath wrote:

> Scott Gray wrote:
>> A good majority of the deprecated methods prior to the last release were deprecated using the javadoc style: /** @deprecated */
>> I updated them post release to use the actual @Deprecated annotation, any opinions on whether we're okay to remove them now or would we be better to wait?
>
> Does javac warn if only javadoc deprecation is used?

After a quick test, the answer is yes.  Leaves me wondering what the point of the annotation is.

[Adam Heath-2]

Scott Gray wrote:
> On 22/01/2010, at 11:14 AM, Adam Heath wrote:
>
>> Scott Gray wrote:
>>> A good majority of the deprecated methods prior to the last release were deprecated using the javadoc style: /** @deprecated */
>>> I updated them post release to use the actual @Deprecated annotation, any opinions on whether we're okay to remove them now or would we be better to wait?
>> Does javac warn if only javadoc deprecation is used?
>
> After a quick test, the answer is yes.  Leaves me wondering what the point of the annotation is.

Don't use a modern compiler that actually understands the annotation.
 Use an older compiler that only understands the javadoc.

[Scott Gray-2]

On 22/01/2010, at 11:32 AM, Adam Heath wrote:

> Scott Gray wrote:
>> On 22/01/2010, at 11:14 AM, Adam Heath wrote:
>>
>>> Scott Gray wrote:
>>>> A good majority of the deprecated methods prior to the last release were deprecated using the javadoc style: /** @deprecated */
>>>> I updated them post release to use the actual @Deprecated annotation, any opinions on whether we're okay to remove them now or would we be better to wait?
>>> Does javac warn if only javadoc deprecation is used?
>>
>> After a quick test, the answer is yes.  Leaves me wondering what the point of the annotation is.
>
> Don't use a modern compiler that actually understands the annotation.
> Use an older compiler that only understands the javadoc.

You've lost me, I see two potential ways to understand what you're saying:
- Do what you're suggesting to properly test if javac warns on javadoc deprecations
Given that prior to annotations being available this was the only way to deprecate something then I'm not sure if that would be necessary?
- Do what you're suggesting to see what the point of the Deprecated annotation is.
I'm not sure how using an older compiler would answer my question?

[Adam Heath-2]

Scott Gray wrote:

> On 22/01/2010, at 11:32 AM, Adam Heath wrote:
>
>> Scott Gray wrote:
>>> On 22/01/2010, at 11:14 AM, Adam Heath wrote:
>>>
>>>> Scott Gray wrote:
>>>>> A good majority of the deprecated methods prior to the last release were deprecated using the javadoc style: /** @deprecated */
>>>>> I updated them post release to use the actual @Deprecated annotation, any opinions on whether we're okay to remove them now or would we be better to wait?
>>>> Does javac warn if only javadoc deprecation is used?
>>> After a quick test, the answer is yes.  Leaves me wondering what the point of the annotation is.
>> Don't use a modern compiler that actually understands the annotation.
>> Use an older compiler that only understands the javadoc.
>
> You've lost me, I see two potential ways to understand what you're saying:
> - Do what you're suggesting to properly test if javac warns on javadoc deprecations
> Given that prior to annotations being available this was the only way to deprecate something then I'm not sure if that would be necessary?
> - Do what you're suggesting to see what the point of the Deprecated annotation is.
> I'm not sure how using an older compiler would answer my question?

The annotation allows you to query it at runtime, instead of it just
being some magical bitflag in the bytecode .class file, that only java
compilers(and other bytecode readers) understand.

I guess that having @Deprecated allows things to detect at runtime,
thru reflection, whether something is deprecated.

[Scott Gray-2]

On 22/01/2010, at 11:46 AM, Adam Heath wrote:

> Scott Gray wrote:
>> On 22/01/2010, at 11:32 AM, Adam Heath wrote:
>>
>>> Scott Gray wrote:
>>>> On 22/01/2010, at 11:14 AM, Adam Heath wrote:
>>>>
>>>>> Scott Gray wrote:
>>>>>> A good majority of the deprecated methods prior to the last release were deprecated using the javadoc style: /** @deprecated */
>>>>>> I updated them post release to use the actual @Deprecated annotation, any opinions on whether we're okay to remove them now or would we be better to wait?
>>>>> Does javac warn if only javadoc deprecation is used?
>>>> After a quick test, the answer is yes.  Leaves me wondering what the point of the annotation is.
>>> Don't use a modern compiler that actually understands the annotation.
>>> Use an older compiler that only understands the javadoc.
>>
>> You've lost me, I see two potential ways to understand what you're saying:
>> - Do what you're suggesting to properly test if javac warns on javadoc deprecations
>> Given that prior to annotations being available this was the only way to deprecate something then I'm not sure if that would be necessary?
>> - Do what you're suggesting to see what the point of the Deprecated annotation is.
>> I'm not sure how using an older compiler would answer my question?
>
> The annotation allows you to query it at runtime, instead of it just
> being some magical bitflag in the bytecode .class file, that only java
> compilers(and other bytecode readers) understand.
>
> I guess that having @Deprecated allows things to detect at runtime,
> thru reflection, whether something is deprecated.

Sounds good to me, thanks.

[Erwan de FERRIERES-3]

Le 22/01/2010 19:48, Scott Gray a écrit :
>> I guess that having @Deprecated allows things to detect at runtime,
>> thru reflection, whether something is deprecated.
>
> Sounds good to me, thanks.
Thanks for the job done. But there is still some messages in the log. As
it was said in the thread, the only reason I raised this mail was to
remove the messages in the log !

Cheers,

--
Erwan de FERRIERES
www.nereide.biz